Last call for patches - 2.3 final is imminent

rubyonrails-core
21

I've tested the new feature for processing records in batches, and I noticed the each method does not work with named_scopes. I attempted to make a simple patch, but added no tests yet.

I think it's a really simple change that can help developers a lot saving time and making the code more DRY.

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2201-batches-each-with-named_scope-doesnt-seem-to-work

Please take a look.

22

I'd like to see this fixed:

#2208 Rails 2.3.1 runs into a segfault - Ruby on Rails - rails, as it concerns Ruby 1.9 and Mysql.

23

I've replaced this with a newer patch: #2209 Patch #3 for HTTP Digest Auth - Ruby on Rails - rails

Don

24

More wood!

http://rails.lighthouseapp.com/projects/8994/tickets/1995-skip_relative_url_root-is-broken

25

Not a blocker, but around I've seen to much custom solutions for running plugin migrations. I created a patch for this, I think it could work for the 95% of the existing applications.

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2058

Cheers, Luca.

26

There's a new regression in RC2 from the autosave logic, on any object with a has_one :through that's been :included (even if autosave is off). Very small patch:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2213-saving-objects-with-associated-has_one-throughs-loaded-broken

Cheers, Will

27

I've been having a lot of issues with the new autosave feature in 2.3 I could easily workaround most of these issues if I had the ability to explicitly disable autosave for certain relationships in such a way that would override the autosave that happens when the association is a "new_record?"

Discussion is here: #2144 Don't autosave new_record associations - Ruby on Rails - rails

I am working on a patch and will be filing a separate ticket for it shortly.

28

I’ve been trying to keep up to speed on all the stuff going into 2.3, but I missed mention of “the new autosave feature”. Google only returns links to lighthouse tickets that aren’t very explanatory. Could someone link me to it?

29

I’ve been having a lot of issues with the new autosave feature in 2.3 I could easily workaround most of these issues if I had the ability to explicitly disable autosave for certain relationships in such a way that would override the autosave that happens when the association is a “new_record?”

You don’t have any issues with the new autosave behaviour, rather with the behaviour which already existed. But we went over that already on the ticket.

Discussion is here: http://rails.lighthouseapp.com/projects/8994/tickets/2144

I am working on a patch and will be filing a separate ticket for it shortly.

Looking forward to it.

Eloy

30

Sure here you go: http://github.com/rails/rails/blob/master/activerecord/lib/active_record/autosave_association.rb

It was part of the NestedAttributes patch so it wasn’t the most interesting feature from that patch I guess :slight_smile:

Eloy

31

Pretty neat. Thanks

32

Just wanted to add this to the list, DDLs in sqlite3 transactions (and
savepoints and version comparison bugfixes to-boot). Koz is already
looking at it - but thought I should mention it in here in case:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2080-sqlite-missing-ddl-transactions-and-savepoints

33

Like most of the one’s mentioned, not a show stopper, but it’s ready and waiting for a commit I think: http://rails.lighthouseapp.com/projects/8994/tickets/1696-problem-with-nested-include-missing-data-and-old-style-single-query-eager-loading

Also, understandably not likely for 2.3, but more eyes and thinking about this one to see if can get into whatever version of rails comes out next would be good: http://rails.lighthouseapp.com/projects/8994/tickets/1619-patch-support-for-inverse-option-in-associations

Cheers,

Muz

34

Hey Eloy,

Thanks for your patience with me... Here's my new ticket and patch for autosave: http://rails.lighthouseapp.com/projects/8994/tickets/2214

35

Small, easy, well tested fixes for radio_button & label:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1993-fradio_button-ignores-parent-fields_fors-index-option

New patch submitted today.

36

Also, this one fixes kind-of a bug:    #2162 layout chaining - Ruby on Rails - rails

At the moment, if you put two layout calls with options into a
controller, then the options will be merged together, but the template
name will be last-in-wins. This can be confusing, and the docs don't
actually say not to put two layout calls in one controller, AND the
layout guide actually gives this as an example of usage.

Instead of fixing the guide, I thought it was a nice idea to have
multiple layout methods, so I wrote this patch - which also fixes the
kind-of bug of conditions being merged but layout names being
overwritten.

37

This seems more like a feature addition and less like a bug fix. I'd
say hold off until after the release for it.

--josh

38

Agree with Josh. Let's refrain from "good to have" stuff and focus on the "must have" patches.

39

There were some hiccups with 1.9 on this one, but they should be fixed in the latest patch I posted :).

40

An association reload oddity to add to the list: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2217-association-reload-fails-due-to-cached-finder_sql