Last call for patches - 2.3 final is imminent

Hey all,

As 2.3 RC2 is out, the plan is to have the 2.3 final release out as early as possible. So we'd like to make the last call for patches. If you have any pending patches that you want in 2.3 final release, please speak now. Not very keen on accepting refactoring patches or new features at this point as they can wait. But if there are any critical bug fixes or anything that should block the release, do post it in the replies.

Thanks for all the contributions. 2.3 is looking really solid !

Hey all,

As 2.3 RC2 is out, the plan is to have the 2.3 final release out as early as possible. So we'd like to make the last call for patches. If you have any pending patches that you want in 2.3 final release, please speak now. Not very keen on accepting refactoring patches or new features at this point as they can wait. But if there are any critical bug fixes or anything that should block the release, do post it in the replies.

The only blocker for me is a Ruby 1.9 issue: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1988

As I wrote in the ticket, this seems to be the only place this is needed due to the nature of the partials+content_for blocks, so magic comments won't work here.

-- Cheers! - Pratik http://m.onkey.org

JS

This isn't a show stopper or a blocker, but it's really simple. http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2122-routing-with-a-blank-path_prefix-causes-a-bad-url-to-generate

Any chance we could get it accepted?

Thanks Andrew

Also not a show stopper but it would e nice to get some eyes on this one. http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2179-activeresource-not-eager-loading-namespaced-models

David Genord II

I'd like to get some eyes on this one as well http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2181-default-scope-with-conditions-on-create

Not a critical blocker, but the first patch in : #2000 Patch for HTTP Digest Authentication URI comparison - Ruby on Rails - rails

has an easy correction to the earlier commit. Other issues re HTTP Digest auth can wait, although I believe it is broken when the connection is sessionless, like from cURL without cookies turned on.

Thanks,

Don

I'd say this is critical, but I don't know who else would agree: http://rails.lighthouseapp.com/projects/8994/tickets/2115-malformed-xml-request-returns-vague-error

This would be really helpful for us here:     #1874 Add short-hand definition for PostgreSQL XML data type - Ruby on Rails - rails

Tks

I have a patch that fixes a lot of the fragility in the current gems:* rake tasks, as well as making unpacking a lot more stable.

Please check it out at:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2195-patch-fix-the-gem-dependency-system-in-rails#ticket-2195-2

The current rake gems tasks do not work in many configurations.

Not a patch, but last I checked assert_select_email didn't work - undefined method in ActionMailer::TestCase subclasses.

Pratik wrote:

Hey all,

As 2.3 RC2 is out, the plan is to have the 2.3 final release out as early as possible. So we'd like to make the last call for patches.

Minor regression, "auto_link should not linkify URLs in the middle of a tag": #1523 auto_link should not linkify URLs in the middle of a tag - Ruby on Rails - rails

When using rails 2.3.1 (does not apply to 2.3.0) I am having issues with destroying sessions (or logging out). It also only applies when using passenger.

Conditions: Rails 2.3.1 Passenger 2.0.6 Both Restful Authentication and Clearance

When using mongrel everything works as it should.

Marshall

Hello! I just joined the group through Google. I hope I'm not intruding, but there's something I would like to see in 2.3:

http://rails.lighthouseapp.com/projects/8994/tickets/1100-json-decoding-of-u-escape-sequences

I don't know if it can be called a blocker, since it doesn't prevent Rails from running, but it causes significant annoyance if JSON is used heavily in an app. It's been extant since 2.0, I think (http://dev.rubyonrails.org/ticket/ 8599) - we've been using a locally-patched Rails for about that long where I work. Earlier today I've reformatted the patch on the Lighthouse ticket so it applies on today's master, and it's very close to being approved.

Marshall,

Check out Passenger 2.1.1 at

There appears to be some compatibility issues with 2.0.6.

James

Yup. You'll need 2.1.1 to run Rails 2.3. I just had a chat with Hongli and he said he'll be trying his best to push the passenger release out asap.

I just installed passenger 2.1.1 and tested both clearance and restful-auth, it fixed the issue with both.

Marshall

This bug here stops Litespeed from working at all on RC2.

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2198-litespeed-compatibility

I consider this Mocha compatibility very important.

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2060-installation-of-miniunit-causes-test-to-fail#ticket-2060-4

Hey all,

As 2.3 RC2 is out, the plan is to have the 2.3 final release out as early as possible. So we'd like to make the last call for patches. If you have any pending patches that you want in 2.3 final release, please speak now. Not very keen on accepting refactoring patches or new features at this point as they can wait. But if there are any critical bug fixes or anything that should block the release, do post it in the replies.

Thanks for all the contributions. 2.3 is looking really solid !

The depot application in the Agile Web Development with Rails, Edition 3 is broken with the current git master (it got considerably further with 2.3rc2). Details:

http://intertwingly.net/blog/2009/03/10/Rails-System-Integration-Testing

-- Cheers! - Pratikhttp://m.onkey.org

- Sam Ruby

Action caching is broken with string keys.

This means you cannot cache XML or JSON responses, for instance, if you use a string for cache key.

Failing test + fix http://rails.lighthouseapp.com/projects/8994/tickets/1585