Proposal to run RuboCop using GitHub Actions

Hi,

I’d like to propose run RuboCop at GitHub - rails/rails: Ruby on Rails using GitHub Actions.

As of right now, RuboCop is running using Code Climate. Here are some restrictions:

  • Need to wait for newer channel like channel: rubocop-0-74 available at Code Climate

Refer Bump RuboCop to 0.74.0 by koic · Pull Request #36943 · rails/rails · GitHub

  • rubocop-0-74 locks RuboCop Performance and RuboCop Rails versions to somewhat lower versions

  • Code Climate runs for pull requests but not for direct push push

With GitHub Actions I think we can unlock these restrictions:

  • Just updating Gemfile and Gemfile.lock to decide which RuboCop, RuboCop Performance and RuboCop Rails versions to run

  • Runs for both direct push and pull requests

I have enabled GitHub Actions to run RuboCop for Oracle enhanced adapter Enable GitHub Actions and run RuboCop by yahonda · Pull Request #1925 · rsim/oracle-enhanced · GitHub

and it has been working fine. Also, I have opened a PoC pull request to my forked repository Enabled GitHub Actions to run latest RuboCop by yahonda · Pull Request #2 · yahonda/rails · GitHub , which looks good to me.

Let me know your thoughts for my proposal.

Thanks,

Hey Yasuo,

I’m fine with it. But I’d leave final call to Eileen who has an open PR to use GitHub actions in general.

Hi Kasper,

Thanks for the reply and sorry for the late reply.

I have opened a pull request Enabled GitHub Actions to run the latest RuboCop 0.76.0 by yahonda · Pull Request #37582 · rails/rails · GitHub to let GitHub Actions run RuboCop because RuboCop 0.76.0 has been just released.

Would like to get some more feedback there.

Thanks,