Should patches to Rails Trac tickets be against SVN or GIT?

rubyonrails-core
1

I noticed yesterday that a patch created against the svn repo that I had submitted in Trac does not work against the latest Git checkout. Should I grab the latest GIT and create my patch against that instead?

- david

2

Yup. svn isn't going anywhere.

Fred

3

http://dev.rubyonrails.org still says to create patches using svn. Are there instructions somewhere on how you would like patches to be made against the git repo?

- david

4

I noticed yesterday that a patch created against the svn repo that I had submitted in Trac does not work against the latest Git checkout. Should I grab the latest GIT and create my patch against that
instead?

Yup. svn isn't going anywhere.

http://dev.rubyonrails.org still says to create patches using svn. Are there instructions somewhere on how you would like patches to be made against the git repo?

trac is also deprecated :slight_smile: http://rails.lighthouseapp.com/ see also tbaggery - Best Practices for Contributing to Rails with Git

Fred

5

Shouldn't the wiki get updated?

Stephen

6

Yes, definitely. I'll try to get something done over the next day or so.