Generated test files and bad require 'test_helper'

rubyonrails-talk
1

Why do the generated test files have: require 'test_helper'

It cannot obviously find the file because it's located in a subdirectory. That's annoying.

2

It finds it ok for me when run from rake test but not from ruby test/unit/test.rb I change all the require lines to

require File.dirname(FILE) + ‘/…/test_helper’

I suspect there is a better way of achieving this effect

Colin

3

Colin Law wrote:

It finds it ok for me when run from rake test but not from ruby test/unit/test.rb I change all the require lines to

require File.dirname(__FILE__) + '/../test_helper'

I suspect there is a better way of achieving this effect

Thanks Colin for your input. Actually it works the same for me (I never noticed), but I often find myself only running a little set of tests and not always the full rake test.

4

Fernando Perez wrote:

Colin Law wrote:

require File.dirname(__FILE__) + '/../test_helper'

I suspect there is a better way of achieving this effect

Thanks Colin for your input. Actually it works the same for me (I never noticed), but I often find myself only running a little set of tests and not always the full rake test.

Some editors run tests in the "wrong" folder - if they can run unit tests at all - so that File.dirname mishmash is crucial for Rails's tests. No idea why the newer version took it out!

5

Fernando Perez wrote: > Colin Law wrote: >> require File.dirname(__FILE__) + '/../test_helper'

>> I suspect there is a better way of achieving this effect > Thanks Colin for your input. Actually it works the same for me (I never > noticed), but I often find myself only running a little set of tests and > not always the full rake test.

Some editors run tests in the "wrong" folder - if they can run unit tests at all - so that File.dirname mishmash is crucial for Rails's tests. No idea why the newer version took it out!

Take a look at the comments for Generated tests rely on test dir in load path rather than File.dirnam… · rails/rails@e817080 · GitHub

Fred

6

Frederick Cheung wrote:

Some editors run tests in the "wrong" folder - if they can run unit tests at all - so that File.dirname mishmash is crucial for Rails's tests. No idea why the newer version took it out!

Take a look at the comments for Generated tests rely on test dir in load path rather than File.dirnam… · rails/rails@e817080 · GitHub

"different relative requires of the same file cause Ruby to load it multiple times. This causes bugs. Fixing it is the point of this change."

Then use File.expand_path(File.dirname(__FILE__) + '/../test_helper.rb').

expand_path - if I spelled it right - goes to the OS filesystem for the uniquely correct path, right?

7

"different relative requires of the same file cause Ruby to load it multiple times. This causes bugs. Fixing it is the point of this change."

Then use File.expand_path(File.dirname(__FILE__) + '/../test_helper.rb').

expand_path - if I spelled it right - goes to the OS filesystem for the uniquely correct path, right?

"File.expand_path doesn’t behave on Windows". It always comes back to that, huh? (-: