Ticket 5205

rubyonrails-core
1

Hi all,

Thought I'd dig up an old old ticket: 5205. Short version: auto_link_urls is overly restrictive in the characters it accepts as part of a url. There's a patch there for it. Unfortunately the particular bit that has been changed is the regular expression, which has become rather illegible. I did however add some tests (which the original implementation failed) I wrote a patch a year or so ago and then mostly forgot about it, but I'm happy to do whatever is needed to bring it up to date.

Anyone care to weigh in ?

Fred

2

Maybe everyone is just at railsconf like me, but does no one at all care about this ?

Fred

3

Sometimes it’s hard to get the attention of the right people. You might also try #rails-contrib on freenode. Don’t give up!

4

Fred,

You can’t push a patch that is a year old and made obsolete by 5 different changesets after that time. Before trying to raise awareness of some patch, do whatever it takes to bring it up to date first and check if it still makes sense. In this case, I’ve done it for you.

At first I wanted to close it, but then I noticed one of your tests (http://user:password@host.com) still fails. My patch adds support for this, however rare the usage may be.

5

Maybe everyone is just at railsconf like me, but does no one at all care about this ?

Fred,

You can't push a patch that is a year old and made obsolete by 5 different changesets after that time. Before trying to raise awareness of some patch, do whatever it takes to bring it up to date first and check if it still makes sense. In this case, I've done it for you.

At first I wanted to close it, but then I noticed one of your tests (http://user:password@host.com) still fails. My patch adds support for this, however rare the usage may be.

Thanks a lot,

to me the odd thing is that there are so many duplicate tickets: having not seen the ticket status change I assumed it was because no progress had been made - it didn't cross my mind there could be 3 overlapping patches created since for the same basic issue, i thought that people with similar problems would i've found the ticket that I had found and added to that. Anyway, thanks for the tips

Fred

6

It's relatively rare that people will do an exhaustive search for existing tickets before submitting a new one. Many people don't even bother with the most cursory search before clicking "New Ticket". It's one of those inevitable truths of software development, I'm afraid.

- Matt

7

There have been recent changesets fixing auto-link URLs and e-mails. Bitsweat, can the patch discussed here also go in as a part of these enhancements? http://dev.rubyonrails.org/ticket/5205

Thanks.