Test::Unit::TestCase refactoring

I noted that in b0ee1bdf2650d7a8380d4e9be58bba8d9c5bd40e and related commits that
the extensions to TestCase are getting pulled out; what's the correct thing to put into test/test_helper.rb?

--Matt Jones

Use ActiveSupport::TestCase instead of Test::Unit::TestCase :slight_smile:

jeremy

Are you sure? When I changed that (in test/test_helper.rb), none of
the test methods ran, and I
don't see any activity in the log.

Just so you know, I have edge frozen from around five days ago and I
went through and replaced all Test::Unit::TestCase instances in my
test/ directory and all my tests still pass.

Found it - in activesupport/lib/active_support/test_case.rb, test/unit
needs to be required,
or the tests don't get run. Add "require 'test/unit'" after "rescue
LoadError".

--Matt

It's required in railties' test_help.

Otherwise, requiring 'active_support/test_case' will tests even if you
didn't mean to.

jeremy

The relevant line (from railties test_help.rb) was deleted in commit
582aa2ead58eacffca13e7efe94235958ee4db1b
on November 7 - should that be put back?

--Matt

Yes; thanks: 5a4789e :slight_smile:

jeremy