RubyOnRails build 8787 failed

The build failed.

CHANGES

Trying to get all these cleaned up and gone.

Alexey: Some of the reported errors do not reproduce for me. I note you're
running Ruby 1.8.6 on Redhat, while I'm running 1.8.4 on Ubuntu. This may
explain the lack of reproducibility. I'll be trying to reproduce your
environment as closely as possible (it won't be on RedHat, since I don't
have $MegaBucks to spend on a licence, but I might bite the bullet and give
CentOS a go) in the near future.

TEST FAILURES AND ERRORS
-----------------------
Name: test_ordering(FirstSecondHelperTest)
Type: Failure
Message: <"first mail"> expected but was
<"">.

./test/mail_render_test.rb:114:in `test_ordering'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run'

Didn't fail for me. If the purpose of the test is to make sure that a .erb
file gets rendered before a .rhtml file, it looks like the test is doing
it's job -- it's failing in CI -- but why it's failing there and not for
anyone else is a deep mystery.

Name: test_use_helper(MailerHelperTest)
Type: Failure
Message: <"From: tester@example.com\r\nTo: test@localhost\r\nSubject: using helpers\r\nMime-Version: 1.0\r\nContent-Type: text/plain; charset=utf-8\r\n\r\n"> expected to be =~
</Mr. Joe Person/>.

./test/mail_helper_test.rb:76:in `test_use_helper'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run'

Didn't fail for me. Again, there's both a .rhtml and a .erb template for
'use_helper'; the .erb has the tested-for text, while the .rhtml is empty.
I'm guessing a similar root cause to the above failure.

Name: test_use_helper_method(MailerHelperTest)
Type: Failure
Message: <"From: tester@example.com\r\nTo: test@localhost\r\nSubject: using helpers\r\nMime-Version: 1.0\r\nContent-Type: text/plain; charset=utf-8\r\n\r\n"> expected to be =~
</HelperMailer/>.

./test/mail_helper_test.rb:86:in `test_use_helper_method'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run'

Name: test_use_mail_helper(MailerHelperTest)
Type: Failure
Message: <"From: tester@example.com\r\nTo: test@localhost\r\nSubject: using mailing helpers\r\nMime-Version: 1.0\r\nContent-Type: text/plain; charset=utf-8\r\n\r\n"> expected to be =~
</ But soft!/>.

./test/mail_helper_test.rb:91:in `test_use_mail_helper'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
     ./test/../lib/../../actionpack/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run'

Numbers 3 and 4 in a series... Same analysis as above.

Name: test_group_has_many_through_should_use_group_for_count(AssociationsJoinModelTest)
Type: Error
Message: ActiveRecord::StatementInvalid: PGError: ERROR: column "comments.id" must appear in the GROUP BY clause or be used in an aggregate function

: SELECT "comments".* FROM "comments" INNER JOIN posts ON comments.post_id = posts.id WHERE (("posts".author_id = 1)) GROUP BY comments.post_id
    ./test/cases/../../lib/active_record/connection_adapters/abstract_adapter.rb:151:in `log'
    ./test/cases/../../lib/active_record/connection_adapters/postgresql_adapter.rb:407:in `execute_without_counting'
    ./test/cases/helper.rb:38:in `execute'
    ./test/cases/../../lib/active_record/connection_adapters/postgresql_adapter.rb:787:in `select_raw'
    ./test/cases/../../lib/active_record/connection_adapters/postgresql_adapter.rb:774:in `select'
    ./test/cases/../../lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache'
    ./test/cases/../../lib/active_record/connection_adapters/abstract/query_cache.rb:55:in `select_all'
    ./test/cases/../../lib/active_record/base.rb:531:in `find_by_sql'
    ./test/cases/../../lib/active_record/base.rb:1245:in `find_every'
    ./test/cases/../../lib/active_record/base.rb:502:in `find'
    ./test/cases/../../lib/active_record/associations/has_many_through_association.rb:149:in `find_target'
    ./test/cases/../../lib/active_record/associations/association_proxy.rb:132:in `load_target'
    ./test/cases/../../lib/active_record/associations/association_proxy.rb:123:in `method_missing'
    ./test/cases/../../lib/active_record/associations/has_many_through_association.rb:142:in `method_missing'
    ./test/cases/associations/join_model_test.rb:607:in `test_group_has_many_through_should_use_group_for_count'
    ./test/cases/../../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
    ./test/cases/../../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run'

I get this error too. Unfortunately, SQL *really* isn't my forte, so I'm
going to have to pass on this one for now.

Name: test_fragment_caching_in_rjs_partials(FunctionalFragmentCachingTest)
Type: Error
Message: ActionView::TemplateError: undefined method `[]' for nil:NilClass

    On line #1 of usr/ccrb/shared/projects/rubyonrails/work/actionpack/test/fixtures/functional_caching/_partial.erb

This failure is fixed by http://dev.rubyonrails.org/ticket/10733, which I've
just set to verified.

- Matt

Trying to get all these cleaned up and gone.

Thanks Matt.

Alexey: Some of the reported errors do not reproduce for me. I note you're
running Ruby 1.8.6 on Redhat, while I'm running 1.8.4 on Ubuntu. This may
explain the lack of reproducibility.

I don't see the mailer failures on my Mac either. I reverted the
change leading to the postgres error and applied the patch for #10733.
All clear now.

jeremy

Giddie *up*!

Thanks Jeremy. Now I'm off to try and reproduce those other problems that
appear to be a bit... elusive.

Alexey, what would the chances be of my being able to get access to the CI
machine (or another machine with a similar enough environment that the tests
still fail) if I can't get an environment locally that causes the tests to
fail?

- Matt