Problems showing modals when page is loaded with turbolinks

rubyonrails-talk
1

Hello.

I’m trying to use modals for the output of :notices or :errors.

In the application.html.erb I use:

<% flash.each do |name, msg| %> <% if msg.is_a?(String) %>

<%= msg %>

<% end %> <% end %>

``

In my application.js file I use:

var ready; ready = function() {

var modal1 = document.getElementById('#modal1');
if (modal1.length > 0) {
    $('#modal1').openModal();
}

};

$(document).ready(ready); $(document).on(‘page:load’, ready);

``

I tried checking if the string is not null too, but this won’t change a thing. Only if I use:

var ready; ready = function() {

$(‘#modal1’).openModal();

}

$(document).ready(ready); $(document).on(‘page:load’, ready);

``

it works, but then it is shown everytime a page is reloaded an I don’t want this behaviour. Why do those checks not work? Any help would be appreciated.

Kind regards.

2

if ($(“#modal1”).length > 0) { // your code }

``

`document.getElementByID() returns an Element object, these objects don’t have a length method. Since you’re using jquery, why don’t you use it there also?

`