Patch review requested: 4 date/time-related patches

rubyonrails-core
1

Looking for patch reviews for these four date/time-related patches:

1. defect: Time #years_since/ago give different results from #advance and #plus/minus_with_duration when advancing from leap day http://dev.rubyonrails.org/ticket/9865

2. defect: Date #years_since/ago raises Invalid Date error with leap day http://dev.rubyonrails.org/ticket/9864

3. refactor: Time and Date #months_since/ago uses #advance instead of custom logic http://dev.rubyonrails.org/ticket/9863

4. enhancement: Time and DateTime #advance honors :hours, :minutes and :seconds options http://dev.rubyonrails.org/ticket/9825

Thanks, Geoff B

2

All applied. Excellent work!

Best, jeremy

3

Thanks!

One additional patch -- this one adds a :weeks option to Time, Date and DateTime #advance: http://dev.rubyonrails.org/ticket/9866

4

Got it! Thanks.

jeremy