more love for resource_feeder, feedback appreciated

rubyonrails-core
1

Hi all

I've provided another patch for resource_feeder, making the rss 2.0 generation a bit more robust and flexible. It now includes some pubDate for the feed and not just the items, for example, which is probably something that should be there by default. I've also added some docs for the rss piece and a little bit better error handling to make it more user friendly.

This patch also includes an older patch that hasn't been committed that changed the calls to SimplyHelpful use the latest method names - so if nothing else, that should definitely be committed :). As it stands right now, if you checkout the latest SimplyHelpful and ResourceFeeder, ResourceFeeder will just not work since its out of date with the latest SimplyHelpful api.

If this looks good, I'll probably make the same type of changes to the atom piece. Tests are included, and feedback welcome.

thanks, Rob

2

+1 for applying this. I ran into the problem last night of ResourceFeeder not working with the latest SimplyHelpful.

Josh

3

Josh Knowles wrote:

    This patch also includes an older patch that hasn't been committed     that changed the calls to SimplyHelpful use the latest method names -     so if nothing else, that should definitely be committed :). As it     stands right now, if you checkout the latest SimplyHelpful and     ResourceFeeder, ResourceFeeder will just not work since its out of     date with the latest SimplyHelpful api.

+1 for applying this. I ran into the problem last night of ResourceFeeder not working with the latest SimplyHelpful.

Josh

-- Josh Knowles joshknowles@gmail.com <mailto:joshknowles@gmail.com> http://joshknowles.com >

+1. Also I wonder if anyone else has had problems with Simply Helpful and STI classes (it essentially requires them to have their own controller).

4

+bumping for someone in core to take a look. Any help?

5

++++20

I just put in a patch for this. I should have searched first. Doh!

But this has broken most of our projects here at Unspace. Boooo!

Please help!

-hampton.

6

bumping again -- could anyone take a look at the patch and consider applying? I'd like to do more work to resource_feeder (as it doesn't fully comply w/ atom 1.0), but I'd like to see this applied first.

http://dev.rubyonrails.org/ticket/6816

- rob

7

Hi Rob,

8

bumping again -- could anyone take a look at the patch and consider applying? I'd like to do more work to resource_feeder (as it doesn't fully comply w/ atom 1.0), but I'd like to see this applied first.

It's not applying cleanly any more:

$ pap http://dev.rubyonrails.org/attachment/ticket/6816/resource_feeder_patch.diff?format=txt patching file test/rss_feed_test.rb patching file lib/resource_feeder/atom.rb Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file lib/resource_feeder/atom.rb.rej patching file lib/resource_feeder/rss.rb Hunk #2 FAILED at 67. 1 out of 5 hunks FAILED -- saving rejects to file lib/resource_feeder/rss.rb.rej patching file README Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file README.rej

Could you fix it up? I'll apply then.