Limiting test assertion methods in Core

rubyonrails-core
1

There used to be a ton of test assertion helpers in Core like assert_session, assert_cookie, assert_flash, etc. See http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_controller/assertions/deprecated_assertions.rb?rev=4935 for some history. I wasn't around for the extract reason they were removed, but we don't need a helper method for every possible situation in Rails. And assert @response.flash[:notice] isn't that bad.

I noticed 2 new patches that fall under this category today.

http://dev.rubyonrails.org/ticket/8971 http://dev.rubyonrails.org/ticket/8973

Any of these kinds of helpers should be plugin territory.

2

They were pulled out because the API was bloated. Providing access to sessions and flash and cookies in functional tests removed the need for almost 30 assertions.

marcel

3

If the goal is to keep the API streamlined, #8793 (assert_charset) probably isn't a big enough win to bother with. But #8791 (assert_content_type) does allow you to do this:

assert_content_type :js

instead of this:

assert_equal Mime::Type.lookup_by_extension('js').to_s, @response.content_type