(koans) another problem (syntax error)

rubyonrails-talk
1

Hello,

I now trying to solve this one :

Triangle Project Code.

Triangle analyzes the lengths of the sides of a triangle

(represented by a, b and c) and returns the type of triangle.

2

Hello,

I now trying to solve this one :

Triangle Project Code.

Triangle analyzes the lengths of the sides of a triangle

(represented by a, b and c) and returns the type of triangle.

It returns:

:equilateral if all sides are equal

:isosceles if exactly 2 sides are equal

:scalene if no sides are equal

The tests for this method can be found in

about_triangle_project.rb

and

about_triangle_project_2.rb

def triangle(a, b, c) if ((a == b) and (b == c)) return :equilateral if (((a == b) and (b != c)) or ((a != b) and (b == c))) return :isosceles

if ((a !=b) and (b != c)) return :scalene end

But I see this error message :

/about_triangle_project.rb:4:in `require’: ./triangle.rb:27: syntax error, unexpected $end, expecting kEND (SyntaxError)

from ./about_triangle_project.rb:4
from path_to_enlightenment.rb:18:in `require'
from path_to_enlightenment.rb:18

Can anyone give me a tip what I have done wrong ?

you’re missing end(s). if you switch the positions of if and return or if you put it in one line, it should solve the error

return :scalene if ((a !=b) and (b != c))

3

Thanks,

That solved my problem.

Roelof

4

Two option already given are to add some ends, or make them a series of oneliners. But, you could also solve it by making all but the first if, "elsif"s instead. Actually you can make the third one just an else, since that's the only remaining option. You'll still need one more end, though, to end the if-series.

Another way that springs to my twisted little mind, though, is to just see how many unique lengths you have:

  [:equilateral, :isosceles, :scalene][[a,b,c].uniq.length - 1]

Do NOT put something that "clever" in anything actually important, as the lack of clarity isn't worth the conciseness. But it makes a neat little mind-exercise. :wink:

-Dave