Interoperating ActiveResource and ActionController::Responder

Matt_Jones · February 4, 2012, 11:12pm

I've just created a pull request to finally make ActiveResource correctly handle validation errors returned from ActionController::Responder's default JSON handling code. The code also handles the format produced by pre-3.2 Responders *and* the format previously expected by ActiveResource, so it shouldn't break in any application that was working before.

github.com/rails/rails

Make ActiveResource error parsing interoperate with ActionController

rails:master ← al2o3cr:compatible_json_errors

opened 11:06PM - 04 Feb 12 UTC

al2o3cr

+83 -6

This is a revised and expanded version of the solution in pull request #3046. I'…ve added deprecated paths for older-style responses and updated the documentation. To summarize the discussion, ActiveResource currently fails to correctly parse errors issued by `ActionController::Responder` when using the default JSON format. This patch corrects that behavior, and includes handling for both the previously documented format (an "errors" key, with an array of messages) and the previous behavior of `ActionController::Responder` (a hash of attributes and errors, no root key) that was corrected in #3272 for Rails 3.2.

Would appreciate any feedback - it would be nice for the framework to actually work with its own API endpoints...

Thanks,

--Matt Jones