http://dev.rubyonrails.org/ticket/8886

Hi, Can someone from Core apply this patch for SQL Server?

http://dev.rubyonrails.org/ticket/8886

I've tested it, and it works fine.

Thanks,

Rich C.

According to http://wiki.rubyonrails.org/rails/pages/PatchRequirements, you
want to put that comment in the ticket and get two other people to look at
the patch and comment. Once you've got three votes, set the 'approved' tag
on the ticket.

- Matt

Actually, the keyword to use is "verified", not "approved". The verified patches report will only find [PATCH] tickets with the keyword "verified".

> According to http://wiki.rubyonrails.org/rails/pages/
> PatchRequirements, you
> want to put that comment in the ticket and get two other people to
> look at
> the patch and comment. Once you've got three votes, set the
> 'approved' tag
> on the ticket.

Actually, the keyword to use is "verified", not "approved". The

Oops.

verified patches report will only find [PATCH] tickets with the
keyword "verified".

Except the report's broken at the moment... <grin>

- Matt

Except the report's broken at the moment... <grin>

Really? What's not showing up that should be?

Trac's reports are just sql queries, and it 'looks' right to me.

Koz, Check http://dev.rubyonrails.org/ticket/8894 - it doesn't show up
in report#12.

Thanks
-Pratik

Fixed... If I never have to edit a trac report again, it'll be too soon :).

Ok, there's a bunch of tickets now with the verified keyword which
don't have the required three review comments. Could you guys please
take some time to go through those patches and either:

1) Review them, or
2) remove the verified keyword.

All the best.

Heh. Well, looks like you're successfully fetching all tickets with
"unverified" keyword as well :slight_smile:

Example : http://dev.rubyonrails.org/ticket/8532

Fixed... If I never have to edit a trac report again, it'll be too soon :).

That good, huh?

Ok, there's a bunch of tickets now with the verified keyword which
don't have the required three review comments.

Holy lordy heckfire! 97 tickets!

Could you guys please
take some time to go through those patches and either:

I'll do a quick pass over them all to remove the keyword, I can't guarantee
I'll comment on them all, but I'll see how I go...

Thanks for fixing the report.

- Matt

WHERE status IN ('new', 'assigned', 'reopened') and keywords LIKE '%verified%'

WHERE status IN ('new', 'assigned', 'reopened') and keywords LIKE ' verified '

Lets try that for a while :).

Oh no..that's gonna fail as well when verified is in front..I guess
best bet is following as Norbert pointed in irc :

WHERE status IN ('new', 'assigned', 'reopened') and keywords LIKE
'%verified%' and keywords NOT LIKE '%unverified%'

If that works..

WHERE status IN ('new', 'assigned', 'reopened')
  AND keywords LIKE '%verified%' AND keywords NOT LIKE '%unverified%'

Alternative? We could just remove all instances of ‘unverified’ keyword. It doesn’t make sense anyway.

That's what I had before, I think. If there are any other clashes
with other keywords, just remove them.

Here is the report with “unverified” keyword:
http://dev.rubyonrails.org/query?status=new&status=assigned&status=reopened&keywords=%7Eunverified&order=priority

Someone should go through these and remove the redundant keyword. All tickets are considered unverified until verified by the new formal patch review process.

Done.

Koz, may be you can delete report#17.

Shouldn't get close everything under http://dev.rubyonrails.org/report/11 ?

The list is clean from now back to #7300, so there's 5 truly verified
patches in the report now. It's getting slower to review the further I go
back as I'm checking that patches still apply and rebasing where I can. I
could just go and check vote counts, though, if that would be preferred, and
we can handle patch cleanliness later as we re-review tickets. What do
others think would be best?

- Matt