simi
(Josef Šimánek)
1
Hello.
Rails’ generator generator is missing hook for :test_framework and it doesn’t generate some basic dumb test.
I can do this and send pull request, I just want to be sure if this is potentially mergable.
Anyone can review this idea and give me red/green on this feature?
Thanks, Josef
If there is functionality with no tests, a test for that functionality
would be welcome.
simi
(Josef Šimánek)
3
Info taken from rails g generator --help:
Example:
rails generate generator Awesome
creates a standard awesome generator:
lib/generators/awesome/
lib/generators/awesome/awesome_generator.rb
lib/generators/awesome/USAGE
lib/generators/awesome/templates/
I think we should add this file:
test/lib/generators/awesome_generator_test.rb
with some basic template (like https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_unit/helper/templates/helper_test.rb) for start or with pending test.
What do you think Steve? Should I start implementing this?
Dne pátek, 12. července 2013 19:13:16 UTC+2 Steve Klabnik napsal(a):
simi
(Josef Šimánek)
4
I created pull request for this.
https://github.com/rails/rails/pull/11419
Dne pátek, 12. července 2013 19:13:16 UTC+2 Steve Klabnik napsal(a):