button_to should generate <button></button> instead of <input type='submit'>, right ?

Dusan_Orlovic · February 3, 2019, 10:38am

I use button_to 'Label', url a lot. Sometimes I need to add some html, for example icon button_to '<i class='fas fa-search'>Search'.html_safe, url and that is not possible unless I use it with block argument

github.com

rails/rails/blob/9f0928322fe0c1209e9cfd97020129797b5e635d/actionview/lib/action_view/helpers/url_helper.rb#L330


      
          request_token_tag = if form_method == "post"
            request_method = method.empty? ? "post" : method
            token_tag(nil, form_options: { action: url, method: request_method })
          else
            ""
          end
          
          
html_options = convert_options_to_data_attributes(options, html_options)
          html_options["type"] = "submit"
          
          
button = if block_given?
            content_tag("button", html_options, &block)
          else
            html_options["value"] = name || url
            tag("input", html_options)
          end
          
          
inner_tags = method_tag.safe_concat(button).safe_concat(request_token_tag)
          if params
            to_form_params(params).each do |param|
              inner_tags.safe_concat tag(:input, type: "hidden", name: param[:name], value: param[:value])

Would not be better to have <button> as default since it is a more powerful (since it can contain other markup) than input type submit (as a value only simple text is supported) ?

Another reason is that in mini tests, it is easier to write assert_select 'button', 'Label' than `assert_select ‘input[value=?]’, ‘Label’ , right ?

Dusan_Orlovic · February 3, 2019, 12:12pm

Enable button_to to use button without block by duleorlovic · Pull Request #35143 · rails/rails · GitHub here is pull request, it is better to discuss when there is a code

Topic		Replies	Views
button_to with image rubyonrails-talk	1	168	August 10, 2012
Using button_to with a get request rubyonrails-talk	14	439	February 12, 2007
button_to with an image rubyonrails-talk	10	2291	May 11, 2008
<button type="button" rubyonrails-talk	6	124	June 7, 2010
button rubyonrails-talk	8	137	January 26, 2010

button_to should generate <button></button> instead of <input type='submit'>, right ?

Related topics

More Resources