Sven_Fuchs
November 21, 2010, 10:13pm
1
Hey guys, I’ve pushed a bunch of patches and tickets today:
https://rails.lighthouseapp.com/projects/8994/tickets/5969-bump-i18n-and-make-translationhelper-use-new-rescue_format-option#ticket-5969-8
https://github.com/svenfuchs/rails/commit/a0f059618cb6eb46dfb97ef49004da776bf00d4c
With I18n 0.5.0 we’ll ship some improvements to the exception api. This patch makes the translation view helper leverage those improvements (by not catching exceptions itself any more).
https://rails.lighthouseapp.com/projects/8994/tickets/6013-move-19-string-interpolation-syntax-backport-from-i18n-to-activesupport
https://github.com/svenfuchs/rails/commit/85a05662fe7e0b06e9c7cd93cae9c3721058d879
We’ve shipped a backport of 1.9 string interpolation syntax for quite some versions in I18n. Now we’re going to not use String#% anymore but implement our own helper method for it. Meanwhile Rails (and probably others) has started relying on this behavior and it seems appropriate to move this to ActiveSupport (should probably have been done right from the beginning).
https://rails.lighthouseapp.com/projects/8994/tickets/6027-define-respond_to-on-actiondispatchintegrationrunner
https://github.com/svenfuchs/rails/commit/64438c2987b6ead8ec28f5962d7d43fa7f01bc3c
This is just a small bug. ActionDispatch::Integration::Runner implements method_missing but misses respond_to?. This can make tests fail where application code relies on respond_to?
https://rails.lighthouseapp.com/projects/8994/tickets/2986-polymorphic_url-should-handle-sti-better#ticket-2986-13
https://github.com/svenfuchs/rails/commit/2d298f2a140cdc8388bf09ce517dd73b698c7a4e
Ticket was opened by Luke Melia in August. I’ve now extracted an implementation from adva-cms2 that solves the problem and also seems to speed up polymorphic_url due to caching. Caching still needs to be tweaked though.
https://rails.lighthouseapp.com/projects/8994/tickets/1975-allow-to-register-javascriptstylesheet_expansions-to-existing-symbols#ticket-1975-15
https://github.com/svenfuchs/rails/commit/b712476ac3f20d1e976ea431ccf44827c419a281
A ticket from the stone age when engines still were a rather obscure thing and people failed to see a usecase. We clearly have a need for this and thus I’m trying to bump this once again. The patch doesn’t break bc.
My last tickets were lying around for quite a while so I’m trying to raise some attention over here.
Thanks Sven! I'll look through these today.
Sven_Fuchs
November 22, 2010, 5:53pm
3
Awesome
I think I've added a note in the ticket about which branch I've patched against. I'm usually not quite sure about this. Lemme know if something needs to be rebased or something. (I'm hanging out on irc, too.)
Hey guys, I've pushed a bunch of patches and tickets today:
#5969 Bump I18n and make TranslationHelper use new :rescue_format option - Ruby on Rails - rails
Make TranslationHelper#translate use the :rescue_format option in I18… · svenfuchs/rails@a0f0596 · GitHub
With I18n 0.5.0 we'll ship some improvements to the exception api. This patch makes the translation view helper leverage those improvements (by not catching exceptions itself any more).
Can you rebase this one from master? It didn't apply cleanly for me.
#6013 Move 1.9 string interpolation syntax backport from I18n to ActiveSupport - Ruby on Rails - rails
Move 1.9 string interpolation syntax backport from I18n to ActiveSupport · svenfuchs/rails@85a0566 · GitHub
We've shipped a backport of 1.9 string interpolation syntax for quite some versions in I18n. Now we're going to not use String#% anymore but implement our own helper method for it. Meanwhile Rails (and probably others) has started relying on this behavior and it seems appropriate to move this to ActiveSupport (should probably have been done right from the beginning).
I'm still working on this. I'd like to get this patch in the backports
gem. I'm not sure which is more appropriate, AS, or backports:
GitHub - marcandre/backports: The latest features of Ruby backported to older versions.
#6027 Define respond_to? on ActionDispatch::Integration::Runner - Ruby on Rails - rails
add respond_to? to ActionDispatch::Integration::Runner · svenfuchs/rails@64438c2 · GitHub
This is just a small bug. ActionDispatch::Integration::Runner implements method_missing but misses respond_to?. This can make tests fail where application code relies on respond_to?
This is applied.
#2986 polymorphic_url should handle STI better - Ruby on Rails - rails
Make polymorphic_url walk up the inheritance chain for given records … · svenfuchs/rails@2d298f2 · GitHub
Ticket was opened by Luke Melia in August. I've now extracted an implementation from adva-cms2 that solves the problem and also seems to speed up polymorphic_url due to caching. Caching still needs to be tweaked though.
#1975 Allow to register javascript/stylesheet_expansions to existing symbols - Ruby on Rails - rails
Allow registering javascript/stylesheet_expansions to existing symbols · svenfuchs/rails@b712476 · GitHub
A ticket from the stone age when engines still were a rather obscure thing and people failed to see a usecase. We clearly have a need for this and thus I'm trying to bump this once again. The patch doesn't break bc.
I'm still working on these two.
Sven_Fuchs
November 23, 2010, 5:12pm
5
#5969 Bump I18n and make TranslationHelper use new :rescue_format option - Ruby on Rails - rails
Make TranslationHelper#translate use the :rescue_format option in I18… · svenfuchs/rails@a0f0596 · GitHub
With I18n 0.5.0 we'll ship some improvements to the exception api. This patch makes the translation view helper leverage those improvements (by not catching exceptions itself any more).
Can you rebase this one from master? It didn't apply cleanly for me.
Sure. Will do that tomorrow.
#6013 Move 1.9 string interpolation syntax backport from I18n to ActiveSupport - Ruby on Rails - rails
Move 1.9 string interpolation syntax backport from I18n to ActiveSupport · svenfuchs/rails@85a0566 · GitHub
We've shipped a backport of 1.9 string interpolation syntax for quite some versions in I18n. Now we're going to not use String#% anymore but implement our own helper method for it. Meanwhile Rails (and probably others) has started relying on this behavior and it seems appropriate to move this to ActiveSupport (should probably have been done right from the beginning).
I'm still working on this. I'd like to get this patch in the backports
gem. I'm not sure which is more appropriate, AS, or backports:
GitHub - marcandre/backports: The latest features of Ruby backported to older versions.
Oh, I didn't even know about that. Is this required by Rails though? At least ActionPack relies on that String#% patch (routes behavior that uses the %{foo} syntax, iirc) but doesn't seem to require the Backports gem? In that case I'd guess it would need to go into ActiveSupport.
#6027 Define respond_to? on ActionDispatch::Integration::Runner - Ruby on Rails - rails
add respond_to? to ActionDispatch::Integration::Runner · svenfuchs/rails@64438c2 · GitHub
This is just a small bug. ActionDispatch::Integration::Runner implements method_missing but misses respond_to?. This can make tests fail where application code relies on respond_to?
This is applied.
Thank you
#2986 polymorphic_url should handle STI better - Ruby on Rails - rails
Make polymorphic_url walk up the inheritance chain for given records … · svenfuchs/rails@2d298f2 · GitHub
Ticket was opened by Luke Melia in August. I've now extracted an implementation from adva-cms2 that solves the problem and also seems to speed up polymorphic_url due to caching. Caching still needs to be tweaked though.
#1975 Allow to register javascript/stylesheet_expansions to existing symbols - Ruby on Rails - rails
Allow registering javascript/stylesheet_expansions to existing symbols · svenfuchs/rails@b712476 · GitHub
A ticket from the stone age when engines still were a rather obscure thing and people failed to see a usecase. We clearly have a need for this and thus I'm trying to bump this once again. The patch doesn't break bc.
I'm still working on these two.
Anything I can help with here?
fxn
November 23, 2010, 5:20pm
6
We've used the backports gem as inspiration or source for some
backports in AS, but it is not a Rails dependency.
I think if AP was relying on behavior supplied by i18n, we should
continue to use i18n for that support. I mean, we should switch it to
use the new method in i18n.
I'm only worried about end users that inadvertently used this backport.
Hey guys, I've pushed a bunch of patches and tickets today:
#5969 Bump I18n and make TranslationHelper use new :rescue_format option - Ruby on Rails - rails
Make TranslationHelper#translate use the :rescue_format option in I18… · svenfuchs/rails@a0f0596 · GitHub
With I18n 0.5.0 we'll ship some improvements to the exception api. This patch makes the translation view helper leverage those improvements (by not catching exceptions itself any more).
#6013 Move 1.9 string interpolation syntax backport from I18n to ActiveSupport - Ruby on Rails - rails
Move 1.9 string interpolation syntax backport from I18n to ActiveSupport · svenfuchs/rails@85a0566 · GitHub
We've shipped a backport of 1.9 string interpolation syntax for quite some versions in I18n. Now we're going to not use String#% anymore but implement our own helper method for it. Meanwhile Rails (and probably others) has started relying on this behavior and it seems appropriate to move this to ActiveSupport (should probably have been done right from the beginning).
#6027 Define respond_to? on ActionDispatch::Integration::Runner - Ruby on Rails - rails
add respond_to? to ActionDispatch::Integration::Runner · svenfuchs/rails@64438c2 · GitHub
This is just a small bug. ActionDispatch::Integration::Runner implements method_missing but misses respond_to?. This can make tests fail where application code relies on respond_to?
#2986 polymorphic_url should handle STI better - Ruby on Rails - rails
Make polymorphic_url walk up the inheritance chain for given records … · svenfuchs/rails@2d298f2 · GitHub
Ticket was opened by Luke Melia in August. I've now extracted an implementation from adva-cms2 that solves the problem and also seems to speed up polymorphic_url due to caching. Caching still needs to be tweaked though.
This looks good. Can you backport the patch to master too? Then I'll
apply and push both. Thanks!
#1975 Allow to register javascript/stylesheet_expansions to existing symbols - Ruby on Rails - rails
Allow registering javascript/stylesheet_expansions to existing symbols · svenfuchs/rails@b712476 · GitHub
A ticket from the stone age when engines still were a rather obscure thing and people failed to see a usecase. We clearly have a need for this and thus I'm trying to bump this once again. The patch doesn't break bc.
Can you backport this patch to master?
Sven_Fuchs
November 24, 2010, 4:36pm
9
