Backport of keyword parameters for controller tests for Rails 4?

rubyonrails-core
1

I’m trying to add Rails 5 support to an engine which (among other things) has a generator for controller tests.

I’ve ran into the keyword arguments deprecation warning at the bottom of this e-mail, and I’m in a bind now. If I use keyword arguments to get rid of the warnings, I lose Rails 4 compatibility.

So far, I’ve managed to write tests that work in current Rails and previous Rails, and I hope I’ll be able to do that in the future. Is there any chance that the keyword arguments will be backported to Rails 4 via a gem, like strong_parameters were backported to Rails 3?

Thank you,

2

+1 Would really ease transition to Rails 5 if I could write my tests the new way already in Rails 4.

3

I think that might be a good idea.

Do you mind creating an issue and ping @sikachu on it? Or, do you want to take a crack at it? I might be able to look at this tomorrow.

-Prem

4

I don’t think it is necessary. You can still use the same syntax with Rails 4 and Rails 5, you will only see deprecations warnings, and I believe it is acceptable in this case.

5

Alternatively, you can wrap the process call with ActiveSupport::Deprecation.silence for now?

http://edgeapi.rubyonrails.org/classes/ActiveSupport/Deprecation/Reporting.html#method-i-silence

I still feel like having a gem that give support for 4.2 would be nice though, as it would suck when Rails 5.1 comes out … but again, it’s possible that you’ll switch to kwargs syntax by that point and only support 5.0 and 5.1 :slight_smile:

-Prem

6

I’ve created a module to mix into my tests when using Rails 4 that backports the new API. Feel free to grab it: Backport new style controller tests by jcoyne · Pull Request #1419 · projectblacklight/blacklight · GitHub

-Justin