Two patch reviews requested

Hi all,

I was hoping a few people would be able to take a look at two patches for me. The first is http://dev.rubyonrails.org/ticket/10796 - it updates the mime type code to allow you to check for equality by a mime type's symbol, as well as by its string representation. It's already got two +1s, so I'm hoping for one more.

Example: # currently mime = Mime.const_get('HTML') mime == 'application/xhtml+xml' # true mime == :html # false

# after patch mime == 'application/xhtml+xml' # true mime == :html # true

The second patch is probably more controversial - http://dev.rubyonrails.org/ticket/10818. It makes it possible add an :alias key to a route declaration, so that you can reuse previously-declared named routes' options when setting up a new route. The use case driving this is the redundancy in map.root and other routes defined for convenience.

Example: # currently   # from restful_authentication, for instance   map.resources :users   map.resource :session

  # ...   map.login :controller => 'sessions', :action => 'new', :conditions => {:method => :get}   map.logout :controller => 'sessions', :action => 'destroy', :conditions => {:method => :delete}   map.register :controller => 'users', :action => 'new', :conditions => {:method => :get}   # ...

  map.root :controller => 'sessions', :action => 'new'

# after patch   # from restful_authentication, for instance   map.resources :users   map.resource :session

  # ...   map.login :alias => :new_session   map.logout :alias => :session, :conditions => {:method => :delete}   map.register :alias => :new_user   # ...

  map.root :new_session

Also, I'm still compiling feedback on http://dev.rubyonrails.org/ticket/10771 (which allows grouping by multiple fields in AR calculations).

Any comments are appreciated.

Thanks! Ben