This topic needs a title

George1 · February 21, 2013, 11:29pm

Hi Core,

Just wondering what thought has been given to this regression introduced by 3.2.12?

3.2.12 More inclusive fix for regression in joins by oggy · Pull Request #9268 · rails/rails · GitHub

Seems like quite a few have been bitten by this [1] - has a path forward been worked out for the 3.2 branch at least?

Thanks! George

[1]

github.com/rails/rails

Rails 3.2.12 breaks some find_by_sql queries

opened 05:26AM - 12 Feb 13 UTC

closed 03:21AM - 10 Mar 13 UTC

petsound

activerecord

I'm using the [ajaxful_rating](https://github.com/edgarjs/ajaxful-rating) gem on… a project, and upgrading to 3.2.12 broke a complex join query with this [method](https://github.com/edgarjs/ajaxful-rating/blob/rails3/lib/axr/model.rb#L235-L246): ``` # Finds rateable objects by Rate's attribute. def find_statement(attr_name, attr_value, dimension = nil) sql = "SELECT DISTINCT r2.* FROM rates r1 INNER JOIN "\ "#{self.base_class.table_name} r2 ON r1.rateable_id = r2.id WHERE " sql << sanitize_sql_for_conditions({ :rateable_type => self.base_class.name, attr_name => attr_value, :dimension => (dimension.to_s if dimension) }, 'r1') find_by_sql(sql) end ``` Under 3.2.12 this caused a Postgres error: ``` ActiveRecord::StatementInvalid (PG::Error: ERROR: relation "r1" does not exist LINE 5: WHERE a.attrelid = '"r1"'::regclass ^ : SELECT a.attname, format_type(a.atttypid, a.atttypmod), pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod FROM pg_attribute a LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum WHERE a.attrelid = '"r1"'::regclass AND a.attnum > 0 AND NOT a.attisdropped ORDER BY a.attnum ): ``` I was able to get this working under 3.2.12 using a revised method: ``` def find_statement(attr_name, attr_value, dimension = nil) sql = "SELECT DISTINCT r2.* FROM rates r1 INNER JOIN "\ "#{self.base_class.table_name} r2 ON r1.rateable_id = r2.id WHERE " sql << sanitize_sql_for_conditions({ :rateable_type => self.base_class.name.to_s, attr_name => attr_value.to_s, :dimension => (dimension.to_s if dimension) }, 'r1') find_by_sql(sql) end ``` As you can see, I've only added `to_s` to the _rateable_type_ and _attr_name_ conditions. I believe this is related to the [quoting changes](https://github.com/rails/rails/compare/v3.2.11...v3.2.12#L9R29) made to ActiveRecord in 3.2.12, but I don't know the code well enough to pinpoint this yet.

github.com/rails/rails

Rails 3.2.12 breaks where conditions with integer values on columns using table aliases

opened 07:34AM - 12 Feb 13 UTC

closed 08:13PM - 01 Apr 13 UTC

michaelmwu

activerecord

Where conditions with integer values in queries for columns with custom joins us…ing table aliases (or just using table aliases in general) are broken in 3.2.12 The code: ``` ruby Artwork.joins("JOIN revisions AS lr ON artworks.last_revision_id=lr.id").where("lr.id" => 1) ``` Breaks with: ``` ActiveRecord::StatementInvalid: PG::Error: ERROR: relation "lr" does not exist LINE 5: WHERE a.attrelid = '"lr"'::regclass ^ : SELECT a.attname, format_type(a.atttypid, a.atttypmod), pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod FROM pg_attribute a LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum WHERE a.attrelid = '"lr"'::regclass AND a.attnum > 0 AND NOT a.attisdropped ORDER BY a.attnum from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:1153:in `async_exec' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:1153:in `exec_no_cache' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:662:in `block in exec_query' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/abstract_adapter.rb:280:in `block in log' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activesupport-3.2.12/lib/active_support/notifications/instrumenter.rb:20:in `instrument' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/abstract_adapter.rb:275:in `log' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/newrelic_rpm-3.5.5.38/lib/new_relic/agent/instrumentation/active_record.rb:32:in `block in log_with_newrelic_instrumentation' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/newrelic_rpm-3.5.5.38/lib/new_relic/agent/method_tracer.rb:240:in `trace_execution_scoped' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/newrelic_rpm-3.5.5.38/lib/new_relic/agent/instrumentation/active_record.rb:29:in `log_with_newrelic_instrumentation' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:661:in `exec_query' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:1278:in `column_definitions' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/postgresql_adapter.rb:857:in `columns' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:12:in `block in initialize' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:16:in `yield' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:16:in `default' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:16:in `block in initialize' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:56:in `yield' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:56:in `default' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:56:in `block in build_from_hash' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `each' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `map' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `build_from_hash' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/query_methods.rb:327:in `build_where' from /home/mmwu/.rvm/gems/ruby-1.9.3-p194/gems/activerecord-3.2.12/lib/active_record/relation/query_methods.rb:136:in `where' ``` Due to these lines in predicate_builder.rb because ActiveRecord tries to look up the non-existent joined table for integers, from commits 04c2d2e2e4197a1564c33f09d3e52253d845925f and d29235d2a4df94b6db7d3e45ab15a6799363384e ``` ruby when Integer, ActiveSupport::Duration # Arel treats integers as literals, but they should be quoted when compared with strings column = engine.connection.schema_cache.columns_hash[table.name][attribute.name.to_s] attribute.eq(Arel::Nodes::SqlLiteral.new(engine.connection.quote(value, column))) ``` Issue #9257 is related I think

github.com/rails/rails

active_record: Fix regression in predicate builder for join aliases.

rails:master ← dylanahsmith:fix-join-alias-integer-comparison

opened 11:45AM - 12 Feb 13 UTC

dylanahsmith

+9 -1

## Problem Pull #9207 introduced a regression where the predicate builder cause…s an exception to be raised when trying to get the column for quoting integers when compared to an attribute on an aliased table. ## Solution Takes the same approach as Arel, checking if the table exists, and otherwise passing a nil column to quote. Relevant Arel code: https://github.com/rails/arel/blob/master/lib/arel/visitors/to_sql.rb#L144

github.com/rails/rails

AR queries non-existent tables on schema:load since 3.2.12

opened 04:44AM - 16 Feb 13 UTC

closed 01:21AM - 27 Feb 13 UTC

rwz

regression activerecord

3.2.12 has introduced a regression in predicate builder. Some scopes are trying …to query non-existing database table on codeload Here are steps to reproduce - Create a new app ``` $ rails new rails-scope-fail && cd rails-scope-fail ``` - generate a model with an integer column and migrate ``` $ rails g model user name lottery_number:integer && rake db:migrate ``` - add some scopes to the model involving integer values ``` ruby class User < ActiveRecord::Base scope :lucky_winner, where(lottery_number: 13) end ``` - mention User model in `routes.rb`. Devise does that usually. That would guarantee that user model will be loaded on schema:load - run `RAILS_ENV=test bundle exec rake db:drop db:schema:load_if_ruby --trace` - see this: ``` ** Invoke db:drop (first_time) ** Invoke db:load_config (first_time) ** Execute db:load_config ** Invoke rails_env (first_time) ** Execute rails_env ** Execute db:drop ** Invoke db:schema:load_if_ruby (first_time) ** Invoke db:create (first_time) ** Invoke db:load_config ** Invoke rails_env ** Execute db:create ** Invoke environment (first_time) ** Execute environment rake aborted! Could not find table 'users' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/connection_adapters/sqlite_adapter.rb:472:in `table_structure' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/connection_adapters/sqlite_adapter.rb:346:in `columns' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:12:in `block in initialize' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:16:in `yield' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/connection_adapters/schema_cache.rb:16:in `block in initialize' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:56:in `yield' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:56:in `block in build_from_hash' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `map' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/predicate_builder.rb:4:in `build_from_hash' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/query_methods.rb:327:in `build_where' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/relation/query_methods.rb:136:in `where' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activerecord-3.2.12/lib/active_record/querying.rb:9:in `where' /Users/rwz/work/rails-scope-fail/app/models/user.rb:2:in `<class:User>' /Users/rwz/work/rails-scope-fail/app/models/user.rb:1:in `<top (required)>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `block in require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:236:in `load_dependency' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:359:in `require_or_load' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:502:in `load_missing_constant' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:192:in `block in const_missing' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:190:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:190:in `const_missing' /Users/rwz/work/rails-scope-fail/config/routes.rb:2:in `block in <top (required)>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/actionpack-3.2.12/lib/action_dispatch/routing/route_set.rb:282:in `instance_exec' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/actionpack-3.2.12/lib/action_dispatch/routing/route_set.rb:282:in `eval_block' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/actionpack-3.2.12/lib/action_dispatch/routing/route_set.rb:260:in `draw' /Users/rwz/work/rails-scope-fail/config/routes.rb:1:in `<top (required)>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:245:in `load' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:245:in `block in load' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:236:in `load_dependency' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:245:in `load' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:40:in `block in load_paths' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:40:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:40:in `load_paths' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:16:in `reload!' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:26:in `block in updater' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/file_update_checker.rb:78:in `call' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/file_update_checker.rb:78:in `execute' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:27:in `updater' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/routes_reloader.rb:7:in `execute_if_updated' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application/finisher.rb:66:in `block in <module:Finisher>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/initializable.rb:30:in `instance_exec' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/initializable.rb:30:in `run' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/initializable.rb:55:in `block in run_initializers' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/initializable.rb:54:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/initializable.rb:54:in `run_initializers' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application.rb:136:in `initialize!' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/railtie/configurable.rb:30:in `method_missing' /Users/rwz/work/rails-scope-fail/config/environment.rb:5:in `<top (required)>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `block in require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:236:in `load_dependency' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/activesupport-3.2.12/lib/active_support/dependencies.rb:251:in `require' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application.rb:103:in `require_environment!' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/railties-3.2.12/lib/rails/application.rb:297:in `block (2 levels) in initialize_tasks' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:228:in `call' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:228:in `block in execute' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:223:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:223:in `execute' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:166:in `block in invoke_with_call_chain' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:159:in `invoke_with_call_chain' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:187:in `block in invoke_prerequisites' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:185:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:185:in `invoke_prerequisites' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:165:in `block in invoke_with_call_chain' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:159:in `invoke_with_call_chain' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/task.rb:152:in `invoke' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:143:in `invoke_task' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:101:in `block (2 levels) in top_level' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:101:in `each' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:101:in `block in top_level' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:110:in `run_with_threads' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:95:in `top_level' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:73:in `block in run' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:160:in `standard_exception_handling' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/lib/rake/application.rb:70:in `run' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rake-10.0.3/bin/rake:33:in `<top (required)>' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/bin/rake:23:in `load' /Users/rwz/.rbenv/versions/1.9.3-p327-perf/bin/rake:23:in `<main>' Tasks: TOP => db:schema:load_if_ruby => environment ```

github.com/rails/rails

Rails 3.2.12: migrating db throws "Could not find table" error due to interaction between environment, observers, active record, and scopes

opened 06:52PM - 14 Feb 13 UTC

closed 01:12AM - 27 Feb 13 UTC

fraser

regression activerecord

Since upgrading to Rails 3.2.12, we get behaviour along the lines of: ``` $ bun…dle exec rake db:drop && bundle exec rake db:create && bundle exec rake db:migrate rake aborted! Could not find table 'users' ``` In our application, this means we can no longer migrate a DB from scratch. However, I imagine that this issue could have further reaching implications. I created a basic app illustrating this issue: https://github.com/fraser/migration-error-3.2.12. In particular, the commit https://github.com/fraser/migration-error-3.2.12/commit/a2836cf0b45e003cf01263844d60c8cf4a028670 shows the required changes for reproduction. I think what is happening is: ``` $ bundle exec rake db:migrate => loads environment => loads observers => loads UserObserver => loads User => evaluates scope :id_0, where(:id => 0) => executes engine.connection.schema_cache in ActiveRecord::PredicateBuilder => schema doesn't exist since we haven't run migrations yet => Could not find table 'users' ``` I am pretty sure this issue was introduced by https://github.com/rails/rails/commit/921a296a3390192a71abeec6d9a035cc6d1865c8#L3R54. Thanks, Fraser

etc.

Topic		Replies	Views
3.2.12 regression in predicate builder rubyonrails-core	0	195	February 24, 2013
Rails 3.1.3 rubyonrails-core announcement	0	149	November 20, 2011
Looking for comments on a rails patch, lazy association instantiation) rubyonrails-core	1	167	October 28, 2007
Quick Patch Review Request for Serious Defect rubyonrails-core	0	107	September 15, 2007
Complex Finds -- find_by_sql? rubyonrails-talk	1	139	July 29, 2009

This topic needs a title

Related topics

More Resources