saving dirty objects

rubyonrails-core
1

changed_attributes is cleared unconditionally after save (and save!) attempts:

    # Clear changed attributes after they are saved.     def save_with_dirty(*args) #:nodoc:       save_without_dirty(*args)     ensure       changed_attributes.clear     end

I'd expect that to happen only if save succeeds. Which is the rationale?

-- fxn

2

I agree. Do you have a patch?

Best, jeremy

3

Here we go, all AR tests pass (except for an unrelated failure):

   #174 dirty objects shouldn't clear changed attributes after a save failure - Ruby on Rails - rails

-- fxn

4

Thanks Xavier!

jeremy