Rails 4.2 & travel_to is not working

rubyonrails-talk
1

Hi!

I have two projects running Rails 4.2 and using travel_to from ActiveSupport::Testing::TimeHelpers.

In one project everything is working perfectly. But in the second one, my specs are running with the current date/time instead of using travel_to. Here is one example:

it “is only a travel_to test” do

travel_to Time.new(2012, 1, 1, 1, 1, 1) do

expect(Time.new).to eq Time.new(2012, 1, 1, 1, 1, 1)

end

end

``

I’ve already set the rails_helper.rb with:

RSpec.configure do |config|

…

config.include ActiveSupport::Testing::TimeHelpers

end

``

Does anyone know what’s going on?

Thanks.

2

What do Time.current and Time.now give you inside the block?

Colin

3

Bingo!

It’s returning the “travel_to” time.

Do you know why?

Thanks A LOT!!!

4

Bingo!

It's returning the "travel_to" time.

Do you know why?

Can you point to some documentation that says that Time.new() initialises to current? I could not find any.

Colin

5

You can find here:

http://ruby-doc.org//core-2.2.0/Time.html

new → time

new(year, month=nil, day=nil, hour=nil, min=nil, sec=nil, utc_offset=nil) → time

Returns a Time object.

It is initialized to the current system time if no argument is given.

a = Time.new #=> 2007-11-19 07:50:02 -0600

Thanks.

6

You can find here:

Class: Time (Ruby 2.2.0)

new → time

new(year, month=nil, day=nil, hour=nil, min=nil, sec=nil, utc_offset=nil) → time

Returns a Time object.

It is initialized to the current system time if no argument is given.

a = Time.new #=> 2007-11-19 07:50:02 -0600

Yes, you are right, and since that document also says that Time.now is an alias for this, and the docs for travel_to states that Time.now should get the travel_to time (have you tried Time.now in the block?) then it looks like you have found a bug.

Colin

7

From the doc for `travel_to` -- Changes current time to the given time by stubbing Time.now and Date.today to return the time or date passed into this method.

If you change your test to `expect(Time.now).to ...` it will pass.

HTH,

8

You can find here:

Class: Time (Ruby 2.2.0)

new → time

new(year, month=nil, day=nil, hour=nil, min=nil, sec=nil, utc_offset=nil) → time

Returns a Time object.

It is initialized to the current system time if no argument is given.

a = Time.new #=> 2007-11-19 07:50:02 -0600

Yes, you are right, and since that document also says that Time.now is an alias for this, and the docs for travel_to states that Time.now should get the travel_to time (have you tried Time.now in the block?) then it looks like you have found a bug.

I think I have to retract this, since the docs for travel_to state that Time.now and Time.current are stubbed then it means that Time.now is no longer an alias for Time.new(), so there is no guarantee that Time.new() will respect travel_to.

Colin

9

Hi!

I changed my code to use Time.now instead of Time.new and now everything is ok.

Do you know where can I check if this bugs is reported and if no… to report?

Thanks.

10

Hi!

I changed my code to use Time.now instead of Time.new and now everything is ok.

Do you know where can I check if this bugs is reported and if no... to report?

Probably our posts crossed, see my last email for reason why I don't think this is a bug.

Colin