Rails 4.0 and String#encoding_aware?

Sergey_Nartimov · December 21, 2011, 8:56am

I'm going to add deprecation to String#encoding_aware? method and remove all of its usage from rails code as Rails 4.0 supports only ruby 1.9.

Is it reasonable?

Thanks.

bitsweat · December 21, 2011, 2:17pm

Not quite yet: it’s unclear how we’ll be working JRuby, Rubinius, and others, so this check may be needed a while longer.

Jeremy

Yehuda_Katz · December 22, 2011, 9:25am

What do you mean?

Yehuda Katz (ph) 718.877.1325

bitsweat · December 22, 2011, 4:12pm

Encoding support is under active development in Rubinius.

So it’d worth PDIing whether we have 1.9-capable Ruby engines with not-fully-baked encoding support before removing encoding_aware? checks.

(I’m not sure about JRuby’s support, either.)

Yehuda_Katz · December 23, 2011, 1:23am

If there are Ruby engines with only partial 1.9 support, and we want to support them, we should probably PDI whether we are in a position to drop 1.8 support at this time.

Yehuda Katz (ph) 718.877.1325

bitsweat · December 23, 2011, 7:47pm

PDIed. JRuby and Rubinius are sufficiently syntax- and API-ready. Encoding support is under active dev in Rubinius, so any gaps or bugs we flush out will be good pressure. So +1 to remove #encoding_aware?

Sergey_Nartimov · December 23, 2011, 9:46pm

Than I'll start work on it, will prepare PR in couple of days.