Possible bug

Bug in associations or not?

def has_many
if options[:through]
          collection_reader_method(reflection,
HasManyThroughAssociation) <--- FIRST CALL
          collection_accessor_methods(reflection,
HasManyThroughAssociation, false) <-- CALLED AGAIN INSIDE THIS METHOD
else
....

def collection_accessor_methods(reflection, association_proxy_class,
writer = true)
          collection_reader_method(reflection,
association_proxy_class) <-- SECOND CALL WITH SAME ARGUMENTS
....

Looks like collection_reader_method is being called twice with the
same arguments.

Bob Silva

def has_many
if options[:through]
          collection_reader_method(reflection,
HasManyThroughAssociation) <--- FIRST CALL
          collection_accessor_methods(reflection,
HasManyThroughAssociation, false) <-- CALLED AGAIN INSIDE THIS METHOD
else
....

def collection_accessor_methods(reflection, association_proxy_class,
writer = true)
          collection_reader_method(reflection,
association_proxy_class) <-- SECOND CALL WITH SAME ARGUMENTS
....

Looks like collection_reader_method is being called twice with the
same arguments.

This certainly looks strange, did you try removing it? Did the tests
still pass?