Plenty of warnings - low quality of code

Hi,

whenever I use rails (on Ubuntu) with ruby -w option, I get lots of
warnings, e.g.

.../vendor/rails/activerecord/lib/active_record/validations.rb:313:
warning: `*' interpreted as argument prefix
.../vendor/rails/activerecord/lib/active_record/callbacks.rb:200:
warning: `*' interpreted as argument prefix
.../vendor/rails/activerecord/lib/active_record/dirty.rb:40: warning:
`*' interpreted as argument prefix
.../vendor/rails/actionpack/lib/action_controller/routing/
routing_ext.rb:2: warning: method redefined; discarding old to_param
.../vendor/rails/actionpack/lib/action_controller/routing/
recognition_optimisation.rb:55: warning: method redefined; discarding
old recognize_path
.../vendor/rails/actionpack/lib/action_view/base.rb:282: warning:
method redefined; discarding old template
.../vendor/rails/actionpack/lib/action_view/helpers/
translation_helper.rb:16: warning: `*' interpreted as argument prefix
.../vendor/rails/actionpack/lib/action_controller/cgi_ext/session.rb:
24: warning: method redefined; discarding old create_new_id
.../vendor/rails/actionpack/lib/action_controller/cgi_ext/session.rb:
31: warning: method redefined; discarding old initialize
.../vendor/rails/actionpack/lib/action_controller/session/
active_record_store.rb:186: warning: method redefined; discarding old
connection
.../vendor/rails/actionpack/lib/action_controller/rack_process.rb:267:
warning: `*' interpreted as argument prefix
.../vendor/rails/actionpack/lib/action_controller/translation.rb:4:
warning: `*' interpreted as argument prefix
.../vendor/rails/actionpack/lib/action_controller/translation.rb:9:
warning: `*' interpreted as argument prefix
.../vendor/rails/activerecord/lib/active_record/observer.rb:35:
warning: instance variable @observers not initialized
.../vendor/rails/actionpack/lib/action_controller/routing/route_set.rb:
247: warning: instance variable @routes_last_modified not initialized
.../vendor/rails/activerecord/lib/active_record/observer.rb:35:
warning: instance variable @observers not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:74: warning:
instance variable @loaded not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/actionpack/lib/action_view/paths.rb:48: warning:
instance variable @eager_load_templates not initialized
.../vendor/rails/activerecord/lib/active_record/connection_adapters/
abstract_adapter.rb:102: warning: instance variable @active not
initialized
.../lib/feed_interpreter.rb:38:in `parse'
.../app/models/feed.rb:59:in `fetch_feed'
.../app/models/feed.rb:36:in `refresh'

That's annoying. Would be nice and apropriate to be a little bit more
precise in coding. And try the -w option.

regards

I'm sure patches would be gratefully received :slight_smile:

Fred