Patch Review Request: #5147 Allowing any TLD format for the cookie_store domain in Rails 3

rubyonrails-core
1

I've added a patch that fixes the new ":all" domain option for cookie session stores in Rails 3. So, calls like this:

config.session_store :cookie_store, :key => '_mydevelopmentsite_session', :domain => :all

will work on any style TLD.

I use a ".local" TLD on my development machine and the current implementation does not allow for this. It will just fail to create the session, causing ActionController::InvalidAuthenticityToken exceptions. Also, the current code does not work for "co.uk" or "com.au". My patch is much more flexible and should cover most TLDs.

https://rails.lighthouseapp.com/projects/8994/tickets/5147-the-all-domain-option-for-the-cookie-session-store-doesnt-allow-non-standard-tlds-like-local-or-couk

Would any of you be willing to verify the patch works for you?

Thanks, Bryce