options_from_collection_for_select

Check the docs for select_tag and you will see that you are missing the first parameter. Perhaps you meant to use f.select, which is generally the right way to do it.

For the future have a look at the Rails Guide on debugging which will show you techniques that you can use to debug your code.

Colin