libxml backend to xml_mini produces incorrect hash

rubyonrails-core
1

I've added this ticket:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2258-libxml-xml_mini-backend-producing-incorrect-hashes

Showing a case where the libxml backend produces an incorrect hash when performing:

   Hash.from_xml

Would be great to get this fixed before the next release of Rails specifically because I've also got a benchmark showing using libxml is 25x faster with a large XML file than than REXML.

In the ticket is a reference to this repo where I have both the benchmark and a test implementation I'd like feedback on.

   http://github.com/stepheneb/rails_hash_from_xml/tree/master

I'm not sure what is the cleanest way to implement one set of tests for multiple xml_mini backends.

What I've done works but there's probably a better way.

2

I've added this ticket:

#2258 libxml xml_mini backend producing incorrect hashes - Ruby on Rails - rails

Showing a case where the libxml backend produces an incorrect hash when performing:

   Hash.from_xml

Would be great to get this fixed before the next release of Rails specifically because I've also got a benchmark showing using libxml is 25x faster with a large XML file than than REXML.

In the ticket is a reference to this repo where I have both the benchmark and a test implementation I'd like feedback on.

   GitHub - stepheneb/rails_hash_from_xml: Benchmarking ActiveSupport: Hash.from_xml with a 1.7 MB xml file.

I'm not sure what is the cleanest way to implement one set of tests for multiple xml_mini backends.

What I've done works but there's probably a better way.

Here's a new version that adapt's 10 of Aaron's tests for the nokogiri backend and runs them agains all of the alternate xml_mini backends:

libxml fail 2, nokogiri and jdom pass all 10.

ticket updated:

http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2258-libxml-xml_mini-backend-producing-incorrect-hashes#ticket-2258-2

will attach a patch against rails directly if feedback is positive