How to get pull requests reviewed?

shaun · February 7, 2021, 12:26pm

I’ve got a PR for a legit issue that keeps getting stale. What is the best way to go about getting review?

github.com/rails/rails

Extend CSP DSL to support both Content-Security-Policy and Content-Security-Policy-Report-Only headers

rails:main ← vandux:csp_report_only

opened 06:06PM - 03 Nov 20 UTC

vandux

+519 -27

### Summary The CSP documentation specifies that both headers can be present …on the same response with different policies. This PR extends the current CSP DSL to support both Content-Security-Policy and Content-Security-Policy-Report-Only headers. This allows applications to test an alternate CSP configuration in Report Only mode while retaining existing configuration. Useful for testing a new CSP configuration before promoting it to production, a scenario that I encountered at Salesforce and forced us to abandon the use of rails CSP DSL. https://github.com/rails/rails/issues/40452 https://discuss.rubyonrails.org/t/extend-content-security-policy-dsl-to-support-both-enforce-and-report-only-policies-at-the-same-time/73654 https://github.com/rails/rails/pull/31162#issuecomment-397467997 Current DSL creates one header. ``` Rails.application.config.content_security_policy do |p| ... end Rails.application.config.content_security_policy_report_only = true ``` New DSL creates two headers. ``` Rails.application.config.content_security_policy do |p| ... end Rails.application.config.content_security_policy_report_only do |p| ... end ```

Topic		Replies	Views
Extend Content Security Policy DSL to support both enforce and report-only policies at the same time. rubyonrails-core	3	593	September 21, 2026
Why Can't I Set Both Content-Security-Policy + Content-Security-Policy-Report-Only Headers? rubyonrails-talk feature	2	936	April 2, 2025
Adding support for report-to directive to Content Security Policy DSL rubyonrails-core	0	391	August 18, 2019
Adding support for report-to to ActionDispatch::ContentSecurityPolicy rubyonrails-talk feature , actiondispatch	0	157	September 11, 2025
How to accept application/csp-report for a content security policy violation report. Or where did my params go? rubyonrails-talk	5	184	April 12, 2026

How to get pull requests reviewed?

Related topics

More Resources