filter dates from where clause

rubyonrails-talk
1

I’m trying to figure out how to compare my enddate > Time.now in my where clause.

enddate is a date field, I’m just trying to only display products that haven’t expired (by the date field).

I’ve tried…

require ‘time’

products.where([‘enddate > ?’, Time.now])

2

ok, I’ve kind of figured it out. but I need to combine my where clause now…


    require 'time'

    todaydate = Time.new
# set 'todaydate' equal to the current date/time.

    todaydate = todaydate.year.to_s + "-" + todaydate.month.to_s + "-" + todaydate.day.to_s

    @title = @category.name
    @products = @category.products.where( 'draft' => false, 'active' => true, 'funded' => false)


@products = @category.products.where('enddate > ?', todaydate )
3

ActiveRecord will handle converting a Time into something your database understands, so you don’t need to worry about that. You can also write the where clause manually like you did, or you can use arel, which would be my preference. You can also chain .where()'s, since they just return ActiveRecord::Relations and don’t actually execute until they need to. Here’s how you could rewrite your code:

@products = category.products.where( ‘draft’ => false, ‘active’ => true, ‘funded’ => false).where(Product.arel_table[:enddate].gt(Time.now))

``

I would personally define that as a scope on the Product model:

scope :not_expired, → { arel_table[:enddate].gt(Time.now) }

``

And then your code could become:

@products = category.products.not_expired.where( ‘draft’ => false, ‘active’ => true, ‘funded’ => false)

``

I would also probably create scopes for all of those other conditions, or maybe wrap them into a single scope if you can produce a term that accurately describes products that are in that exact state.

4

Thanks. I got it combined. I’ll try using the scope in the product model.