2.2 has the new number_with_precision implementation which after the number takes :precision, :separator, and :delimiter hash arguments instead of just a precision integer, and the old argument format has been deprecated.
Are we really on the right track deprecating things like this? It feels like deprecation for the sake of deprecation to me.
I mean, if you’ve got a method called number_with_precision, it seems pretty clear that the normal two arguments would be the number, and the precision. Being able to supply the separator and delimiter is great, but since most people will just set those on the locale (if at all), surely we’re just making people do a bunch of extra typing & change a lot of calls in their existing code for no good reason, merely to get rid of the deprecation?
The code already supports both argument syntaxes, so I think we should just remove the deprecation warning. IMHO, we don’t have to deprecate every time something slightly more flexible comes along if there’s nothing wrong with the old way - provided there’s no confusion between the old & new syntax or semantics.