Using find in IP-ranges

rubyonrails-talk
#1

So I've converted the IPs to integers using IPAddr, which makes it a
whole lot easier to see if an incoming IP fits a certain range.

The code I'm looking at now is:

@request_ip = IPAddr.new(request.remote_ip)
ips = IpRanges.find(:all)
ips.each do |ip|
  range = ip.start_ip_integer..ip.end_ip_integer
  if range.include?(@request_ip.to_i)
    @ip_range = ip
  end
end
render :text => @ip_range.group

Looks painfully slow to iterate thru every row like that - and I keep it
all in my controller when I assume it should be refactored into my
IpRange-model?

Any way to speed things up?

#2

Probably the way to speed it up the most is with SQL. Something like
this might work:

IpRanges.find(:all, :conditions => ['start_ip_integer <= :ip AND
end_ip_integer >= :ip', {:ip => @request_ip.to_i}])

That would probably be in a class method in your model.

I hope that helps,
Paul