Testing uncommon HTTP methods fails (like options)

Mauricio_Linhares1 · February 18, 2014, 3:41pm

Hello everyone,

Could someone check this PR?

github.com/rails/rails

Fixes issue with process method not visible in integration tests

rails:master ← mauricio:fix-process-on-integration-tests

opened 02:12PM - 15 Feb 14 UTC

mauricio

+81 -61

Since `process` was private in `ActionDispatch::Integration::RequestHelpers::Ses…sion`, when you call `process` inside an integration test it would never call `process` at the current session as Ruby 2.0 and onwards only checks for public methods and `process` being private is always a false result when `method_missing` gets called inside `ActionDispatch::Integration::RequestHelpers::Runner`. Making it public allows it to be called again inside integration tests and fixes rspec/rspec-rails#925.

This affects both Rails and Rspec tests that use methods that are not defined at the integration session api (like options).

Topic		Replies	Views
Inconsistent Method Visibility rubyonrails-core	2	120	March 13, 2007
alias_method_chain :process rubyonrails-talk	1	171	May 26, 2009
Why need before_validation etc methods be public? rubyonrails-talk	5	144	October 14, 2009
Testing private methods rubyonrails-talk	7	86	January 6, 2010
about private method test rubyonrails-talk	3	112	November 16, 2008

Testing uncommon HTTP methods fails (like options)

Related topics

More Resources