Should Flash::add_flash_types be public?

While playing around with gem traceroute (0.5.0) I noticed that my additional flash types:


add_flash_types :success

add_flash_types :error


are “leaking” into public scope of every controller descendent of ApplicationController:


I wonder if add_flash_types should define the new methods as protected, since it might lead into conflicts with actual controller actions.

You can see this “leaking” with the gem or just with this: { |ctrl| { |action| + “#” + action




This is trivial to accomplish - simply change it to:

#… define_method(type) do


end protected type

helper_method type #…