Request for review: PR #57863

Gaston_Ramos · September 1, 2026, 1:30pm

Hi!

I’m looking for feedback on PR #57863:

github.com/rails/rails

Fix alias_attribute precedence over included modules (#57863)

main ← gramos:issue-50048-alias-attribute-concern-override

opened 09:09PM - 25 Jun 26 UTC

gramos

+90 -4

### Motivation / Background Fixes #50048. `alias_attribute` should allow a…n attribute alias to override a method with the same name that comes from an included module. For example, if a model includes a module that defines `display_name`, and the model then declares `alias_attribute :display_name, :title`, calling `display_name` should read the `title` attribute. Before this change, the method generated for the alias was defined in `GeneratedAttributeMethods`. Included modules can appear before `GeneratedAttributeMethods` in the ancestor chain, so Ruby resolved the method from the included module first and never reached the generated alias method. ### Detail This Pull Request detects when an alias attribute method would be generated below an existing method with higher precedence in the ancestor chain. In that case, it generates the alias methods in a separate `GeneratedAliasAttributeMethods` module that is included with higher precedence. Aliases without that conflict continue to use `GeneratedAttributeMethods`, so the normal alias generation path remains unchanged. The change also clears generated alias methods when attribute methods are undefined, matching the existing regeneration lifecycle for generated attribute methods. ### Additional information A regression test covers an included module defining the alias reader before `alias_attribute` is declared. Validation run locally with Ruby 3.4.9: ```bash cd activerecord bin/test test/cases/attribute_methods_test.rb -i "/alias_attribute override methods defined in included modules/" bin/test test/cases/attribute_methods_test.rb -i "/alias_attribute/" bin/test test/cases/attribute_methods_test.rb ``` RuboCop: ```bash bundle exec rubocop activerecord/lib/active_record/attribute_methods.rb activerecord/test/cases/attribute_methods_test.rb ``` ### Checklist * [x] This Pull Request is related to one change. Unrelated changes should be opened in separate PRs. * [x] Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: `[Fix #issue-number]` * [x] Tests are added or updated if you fix a bug or add a feature. * [x] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature.

The PR fixes alias_attribute overriding methods defined in included modules.

I recently rebased it onto the latest main, resolved the changelog conflict, and verified the relevant Active Record tests:

136 runs, 613 assertions, 0 failures, 0 errors.

Any review or feedback would be greatly appreciated. Thanks!

Topic		Replies	Views
I would like an idea to create an issue about add alias_attribute to method "attributes" rubyonrails-core	10	1410	July 24, 2023
Overriding AR read/write_attribute - Overridden write_attribute Is Never Called rubyonrails-talk	5	597	September 25, 2009
Aliasing AR attributes rubyonrails-talk	2	202	June 17, 2009
What to do when two mixins need to hook into attribute= of an ActiveRecord rubyonrails-talk	7	330	November 28, 2006
[Patch for Review] dirty methods on attribute aliases rubyonrails-core	2	210	August 21, 2008

Request for review: PR #57863

Related topics

More Resources