I just launched a new tool for Open Source projects: Pull Request Roulette (http://www.pullrequestroulette.com). Check it out and let me know what you think.
I just launched a new tool for Open Source projects: Pull Request Roulette (http://www.pullrequestroulette.com). Check it out and let me know what you think.
This is a great idea, but the very first one I see here has already been closed. What's your plan for adding items and policing the list?
Walter
I just launched [...] http://www.pullrequestroulette.com
This is a great idea, but the very first one I see here has already been closed.
Yeah, I just noticed that this morning. Hadn't really thought of what to do about that.
What's your plan for adding items and policing the list?
The first thing that comes to mind is crowdsourcing. If you see it's been closed, "Take" it.
(For now that's really just Destroy, renamed. Later I'll be keeping historical records of who submitted and "took" which ones when. This will require logging in with your Github credentials. That will also enable profiles, which in turn enables lots of other features I have in mind, such as saying what languages you will review, ratings for coders and reviewers, etc.)
Later I might have it actually verify, when a PR is submitted, that it's still open, and possibly again before showing it to someone (after I've got the "match by languages", "keep a queue", and "present one at a time" functionalities in). IIRC the Github API supports that pretty easily.
If you've got other ideas, for either features or implementation, suggest away! That's one reason I encourage people to browse the issue list.
Thanks, Dave
BTW, I've just added a "Verify that a PR is still open" issue, as follows:
As a reviewer, I want to see only PRs that are still open, So I don't waste time checking into closed ones.
Scenario 1: Given that my PR is already closed, When I submit it, Then I should get an error message saying so, And it should not be accepted.
Scenario 2: Given that a PR has been closed since submission, When someone asks for a PR and it's that one's turn, Then the system should skip that PR And the system should remove it from the queue.
-Dave
Update: it now makes sure that not only is the URL in the correct format for a Github pull request, but it actually IS one, and is still open (at least when it's submitted or edited).
-Dave