Need help with my sql

Alan Red wrote:

<%= rating = Product.connection.select_all("select comment,
seller_rating, advert_rating from ratings ")%>

Since you are just doing a database query and not getting any model
objects, you will get an array of hashes as the result. Each hash will
map the column name from your query to its value.

Your "<%=" then means output this value. When you ask Ruby to print a
hash, it just rubs together keys and values as you are seeing.

Firstly, you have model specific code in your view. If the ratings
table changes, you will need to hunt through your code for things like
this and change them.

If you have a ratings table, then do you not have a Ratings model? Why
use another model (Product) to look up a Rating? It looks like you
actually want your lookup to be:

Rating.find(:all)

Much simpler and no SQL.

Then you can go through then printing them out something like this:

<% Rating.find(:all) do |rating| %>
  Seller rating: <% rating.seller_rating %><br />
  Advert rating: <% rating.advert_rating %><br />
  Comment: <% rating.comment %><br />
  <hr />
<% end %>

If you do find yourself needing to run SQL to get some results, decide
what model is best associated with the query and add a method to that
model to get the data. Then elsewhere, you just need to call that
method and use the results.

Mark Bush wrote:

Alan Red wrote:

<%= rating = Product.connection.select_all("select comment,
seller_rating, advert_rating from ratings ")%>

Since you are just doing a database query and not getting any model
objects, you will get an array of hashes as the result. Each hash will
map the column name from your query to its value.

Your "<%=" then means output this value. When you ask Ruby to print a
hash, it just rubs together keys and values as you are seeing.

Firstly, you have model specific code in your view. If the ratings
table changes, you will need to hunt through your code for things like
this and change them.

If you have a ratings table, then do you not have a Ratings model? Why
use another model (Product) to look up a Rating? It looks like you
actually want your lookup to be:

Rating.find(:all)

Much simpler and no SQL.

Then you can go through then printing them out something like this:

<% Rating.find(:all) do |rating| %>
  Seller rating: <% rating.seller_rating %><br />
  Advert rating: <% rating.advert_rating %><br />
  Comment: <% rating.comment %><br />
  <hr />
<% end %>

If you do find yourself needing to run SQL to get some results, decide
what model is best associated with the query and add a method to that
model to get the data. Then elsewhere, you just need to call that
method and use the results.

I should have explained what product is, I have two tables product has
product details and rating holds details for the product (users will
rate products). I want them to be able to move to a page and the comment
related to that pages item will appear.

e.g

Product's details

Then comments from the rating table related will appear here.

Im only getting started with rails so I don't know much about its ins
and outs. Im not sur how to do methods in models and the databases,
along with pages were created using scaffold.

Alan Red wrote:

I should have explained what product is, I have two tables product has
product details and rating holds details for the product (users will
rate products). I want them to be able to move to a page and the comment
related to that pages item will appear.

So your models are like this:

class Product < ActiveRecord::Base
  has_many :ratings
end

class Rating < ActiveRecord::Base
  belongs_to :product
end

?

In your Product show method, you are probably doing something like:

@product = Product.find(params[:id])

?

If so, then update this to:

@product = Product.find(params[:id], :include => :ratings)

Then, in your view, you can display your Product object (@product), then
to display the ratings for that product something like:

<% @product.ratings.each do |rating| %>
  Seller rating: <% rating.seller_rating %><br />
  Advert rating: <% rating.advert_rating %><br />
  Comment: <% rating.comment %><br />
  <hr />
<% end %>

Is this more what you have in mind?

If not, can you explain more about your class definitions, tables, how
they are related and then the output you want in those terms?