Change AR::ConnectionAdapters::SchemaStatements#add_index to take kwargs

rubyonrails-core
1

Hi,

I’m always confused by the existence of uniq and unique. Arrays and ActiveRecord::Relation objects respond to uniq while AR::ConnectionAdapters::SchemaStatements#add_index takes :unique option. I would like to get notified when :uniq option is actually wrong. If we change #add_index to take kwargs, it’ll raise an error when :uniq option is given.

Does this make sense? Thanks for your time again!

Thanks,

Yuki

2

Never mind, I guess the train I was on last week was way too old: https://github.com/rails/rails/commit/8fc52706c376be03f644e847d1dd357fc88ead6f