Appropriate way to remove an accepted commit?

rubyonrails-core
1

I found a commit that was merged into master that actually breaks FormOptionHelper#time_zone_options_for_select. I seem to keep running into these. :slight_smile:

The commit in question is here: Use #grep to filter priority zones when a regexp is given 路 rails/rails@b4051ed 路 GitHub

I have commented on the commit explaining the problem. I am not clear on what the standard procedure is for simply removing a commit from Rails though which is what I think should be done here essentially. I can create a new PR that puts things back how they were before the commit but I鈥檓 not sure if that鈥檚 the right way or if you guys would rather just unwind the changes and do some git magic to remove the commit completely from history?

If a PR to remove it is appropriate I can work one up pretty fast.

2

Submit a PR that reverts that commit.

3

Thanks Steve, done.

https://github.com/rails/rails/pull/9680

4

It would be a great idea to add a test to the PR along with the revert so that the problem doesn鈥檛 happen again.