Ryan10
September 1, 2018, 9:54am
1
#freeze_time . It could help users if there was a complementary method called #unfreeze_time
This could mean that a developer could write a test that would stub time at Time.now using #freeze_time , then could call #unfreeze_time when they want to unstub Time
I would like to propose this new feature, however this is my first time suggesting a feature in this group so please advise how to take this further if rails contributors like the idea.
fxn
September 2, 2018, 2:08pm
2
How would that method differ from the existing travel_back? If there is a difference, which would be a use case?
Ryan10
September 2, 2018, 5:20pm
3
It could be set as an alias for #travel_back .
From a semantic perspective #unfreeze_time would read like an opposite to #freeze_time , just like #travel_back is an opposite of #travel_to
It’s a relatively small change that could improve the user experience of using #freeze_time
fxn
September 2, 2018, 10:17pm
4
I think it makes sense. For the code to read well, both verbs have to match.
Would you like to contribute a patch?
Would this be easier if freezing time took place in a block, and any unfrozen time followed the closure of the block? Then we wouldn’t need a separate method. I think this was the recommended practice with Timecop.
fxn
September 3, 2018, 12:31am
6
Would this be easier if freezing time took place in a block, and any
unfrozen time followed the closure of the block? Then we wouldn't need a
separate method. I think this was the recommended practice with Timecop.
Right. Generally you'd do that, but there are use cases for calls without
blocks.
Anyway, the interface without blocks exists, so the symmetry
freeze/unfreeze has to be provided from an API point of view.
Ryan10
September 3, 2018, 9:16pm
7
Yes I’d love to contribute a patch for this.
I posted it as an issue in the rails repo and they directed me here. Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers · Issue #33771 · rails/rails · GitHub
Could you advise on your normal process for this? I’ve contributed a rails before, but that was for an issue someone else had created.
fxn
September 4, 2018, 2:12pm
8
On Mon, Sep 3, 2018 at 11:16 PM, 'Ryan' via Ruby on Rails: Core <
Yes I'd love to contribute a patch for this.
I posted it as an issue in the rails repo and they directed me here.
Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers · Issue #33771 · rails/rails · GitHub
Could you advise on your normal process for this? I've contributed a rails
before, but that was for an issue someone else had created.
Sure, there is a guide that might help you:
Contributing to Ruby on Rails — Ruby on Rails Guides
Please, don't hesitate to ask for help if the guide is not enough, feel
free to write to me directly.
Ryan10
September 4, 2018, 5:47pm
9
Right, I see the process is to fork rails and and make a PR with the patch. Thanks for the tips, and for the offer of further support.
Ryan10
September 7, 2018, 10:14am
10
