Hi Rails Core,
I would like to tackle https://github.com/rails/rails/issues/17706 , but I have some questions.
- Do we want the change? ( isolated ‘test’ https://gist.github.com/mess110/89f45de57fe8657da400 )
If we do,
-
Is the suggested approach good? (the one in the issue)
-
I was looking though the tests and I found 2 places where it could fit. Which is better?
-
rails/activerecord/test/cases/adapters/postgresql/json_test.rb (json related tests)
-
rails/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb (distinct related tests)
-
Going though the docs, I found:
- http://apidock.com/rails/ActiveRecord/QueryMethods/distinct
- http://apidock.com/rails/ActiveRecord/Associations/CollectionProxy/distinct
-
http://apidock.com/rails/ActiveRecord/Associations/CollectionAssociation/distinct
What do you think?
Thanks,
Cristian